|
Home > Archive > Samba > June 2004 > [Samba] Re: string overflow in safe_strcpy
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
[Samba] Re: string overflow in safe_strcpy
|
|
| Carl Matthews 2004-06-29, 3:03 am |
| Also i've just noticed the errors never occur for directorys but only
for files longer than the 8.3. Which again suggests an error in the hash
mangling method.
Carl wrote:
>
> I updated our server to 3.0.5pre1 this morning from the fc1 rpms linked
> by samba.org.
> But the errors persist, But like corey they do dissappear when "mangling
> method = hash" is rem'd out but this then makes long file names
> unreadable to programs that use 8.3 filenames, like some of the old
> compilers we use here.
>
> The errors occur at the sametime as Corey's when ever you browse a share
> you get an error for all the files in that directory.
>
> Is there any more info you might need to track this down?
>
> Thanks,
> Carl Matthews
>
> sample of my log file :
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: ERROR: string overflow by 1
> (57 - 56) in safe_strcpy [Software & Driver downloads HP Officejet g55
> All-]
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: [2004/06/29 08:41:16, 0]
> lib/util_str.c:safe_strcpy_fn(600)
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: ERROR: string overflow by 1
> (9 - 8) in safe_strcpy [HP OF~YU.URL]
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: [2004/06/29 08:41:16, 0]
> lib/util_str.c:safe_strcpy_fn(600)
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: ERROR: string overflow by 1
> (97 - 96) in safe_strcpy [HP Officejet g55 All-in-One HP OfficeJet G
> Series]
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: [2004/06/29 08:41:16, 0]
> lib/util_str.c:safe_strcpy_fn(600)
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: ERROR: string overflow by 1
> (9 - 8) in safe_strcpy [28-06~LT.ZIP]
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: [2004/06/29 08:41:16, 0]
> lib/util_str.c:safe_strcpy_fn(600)
> Jun 29 08:41:16 mandrake1 nss_wins[27719]: ERROR: string overflow by 1
> (20 - 19) in safe_strcpy [28-06-2004 09-56-06.zip]
>
> I updateJeremy Allison wrote:
>
>
>
--
To unsubscribe from this list go to the following URL and read the
instructions: http://lists.samba.org/mailman/listinfo/samba
| |
| Jeremy Allison 2004-06-29, 5:50 pm |
| On Tue, Jun 29, 2004 at 09:13:05AM +0100, Carl Matthews wrote:
> Also i've just noticed the errors never occur for directorys but only
> for files longer than the 8.3. Which again suggests an error in the hash
> mangling method.
Ok, I'll take a look at this - thanks !
Jeremy.
--
To unsubscribe from this list go to the following URL and read the
instructions: http://lists.samba.org/mailman/listinfo/samba
| |
| Jeremy Allison 2004-06-29, 5:50 pm |
| On Tue, Jun 29, 2004 at 09:13:05AM +0100, Carl Matthews wrote:
> Also i've just noticed the errors never occur for directorys but only
> for files longer than the 8.3. Which again suggests an error in the hash
> mangling method.
Here's the fix. Incorrect use of safe_strcpy (memcpy should be used instead).
Jeremy.
|
|
|
|
|