Apache Mod-Python - Re: Commented: (MODPYTHON-93) Improve util.FieldStorage

Author

Re: Commented: (MODPYTHON-93) Improve util.FieldStorage

Gregory (Grisha) Trubetskoy

2005-11-29, 5:49 pm

On Tue, 29 Nov 2005, Jim Gallacher wrote:

> I still think the correct place to create the index dictionary is in the
> __init__ phase. Using the dictionary-on-demand idea only improves performance
> on the second access to a form field. For the first access you are still
> iterating through the whole list for each field name.

I am still not convinced we need an index. I'd like to see some concrete
proof that we're not engaging in "overoptimization" here - is this really
a bottleneck for anyone?

If we're concerned (and I'm not at this point) that FieldStorage is too
slow, we should just rewrite the whole thing in C :-)

Grisha