| Graham Dumpleton (JIRA) 2006-03-05, 2:45 am |
| [ http://issues.apache.org/jira/brows...THON-7?page=all ]
Graham Dumpleton closed MODPYTHON-7:
------------------------------------
> Autoreload works if mtime is newer, but not older.
> --------------------------------------------------
>
> Key: MODPYTHON-7
> URL: http://issues.apache.org/jira/browse/MODPYTHON-7
> Project: mod_python
> Type: Improvement
> Versions: 3.1.3
> Reporter: Graham Dumpleton
> Assignee: Nicolas Lehuen
> Priority: Minor
> Fix For: 3.2.7
>
> The apache.import_module() method only reloads a Python module if the modification time of the file on disk is newer. This means that if one restores an old version of a file from backup, eg., by using "mv" command from another location, it will not rel
oad it and it is necessary to touch the file or restart Apache.
> The check in apache.py, instead of being just:
> if mtime > oldmtime:
> could perhaps be:
> if mtime != oldmtime:
> I don't believe this would cause any wider issues, but might be due some thought first.
> The various settings of mtime and oldmtime above that in the code, ie., to 0 or 1, will also have to be reviewed to ensure this change doesn't break anything.
|