| Graham Dumpleton (JIRA) 2006-05-07, 7:11 am |
| [ http://issues.apache.org/jira/brows...ON-103?page=all ]
Graham Dumpleton reopened MODPYTHON-103:
----------------------------------------
Reopened because using PythonInterpPerDirective in conjunction with dynamically registered filters causes mod_python to crash. Problem code is in select_interp_name().
py_handler *fh;
if (fname) {
if (is_input) {
fh = (py_handler *)apr_hash_get(conf->in_filters, fname,
APR_HASH_KEY_STRING);
} else {
fh = (py_handler *)apr_hash_get(conf->out_filters, fname,
APR_HASH_KEY_STRING);
}
s = fh->directory;
}
else {
s = hle->directory;
}
For a dynamically registered filter, fname is "mod_python" and the context provided with the filter handler is used to get details of dynamically registered filter. This information isn't available or used by select_interp_name() which assumes that filter
is part of globally registered filters. It will not find the filter and so "fh" is NULL and accessing directory attribute causes a crash.
> Implement req.add_output_filter().
> ----------------------------------
>
> Key: MODPYTHON-103
> URL: http://issues.apache.org/jira/browse/MODPYTHON-103
> Project: mod_python
> Type: New Feature
> Components: core
> Reporter: Graham Dumpleton
> Assignee: Graham Dumpleton
> Fix For: 3.3
> Attachments: grahamd_20060108_1_requestobject.c.diff, grahamd_20060108_2_multiple.diff
>
> Add new member function to request object called "add_output_filter()". This would be a wrapper around the function "ap_add_output_filter()" and allow previously defined filters to be attached to the current request such that output can be filtered thro
ugh them. For example:
> req.add_output_filter("INCLUDES")
> It would probably be necessary for any such call to be done prior to the first output being generated from the request handler.
> In addition to this member function, it may be necessary to also provide another member function called something like "req.add_python_output_filter()". This would be called something like:
> req.add_python_output_filter("module_name::filter_name",path)
> Ie., like "req.add_handler()" but no first argument for phase.
> This method would allow a specific Python filter handler function to be specified. This would be equivalent to using the PythonOutputFilter directive to first name a mod_python based filter handler function and then adding it as an output filter.
> # Main Apache config.
> PythonOutputFilter module_name::filter_name MYFILTER
> # Handler code.
> req.add_output_filter("MYFILTER")
> Note that the PythonOutputFilter directive can only be used in the main Apache configuration file, it cannot be used in a .htaccess file. Whether it could be made to work in a .htaccess file in some way needs to be investigated. In mod_perl their equivl
ent seems to allow it.
|