| Jim Gallacher (JIRA) 2006-06-30, 1:11 am |
| [ http://issues.apache.org/jira/brows...HON-93?page=all ]
Jim Gallacher reopened MODPYTHON-93:
------------------------------------
Reopened issue due to problems experienced by some applications such as Trac.
We'll need to re-examine the code committed to make sure that FieldStorage behaves properly as a dictionary-like object.
> Improve util.FieldStorage efficiency
> ------------------------------------
>
> Key: MODPYTHON-93
> URL: http://issues.apache.org/jira/browse/MODPYTHON-93
> Project: mod_python
> Type: Improvement
> Components: core
> Versions: 3.2.7
> Reporter: Jim Gallacher
> Assignee: Jim Gallacher
> Priority: Minor
> Fix For: 3.3
> Attachments: modpython325_util_py_dict.patch
>
> Form fields are saved as a list in a FieldStorage class instance. The class implements a __getitem__ method to provide dict-like behaviour. This method iterates over the complete list for every call to __getitem__. Applications that need to access all
the fields when processing the form will show O(n^2) behaviour where n == the number of form fields. This overhead could be avoided by creating a dict (to use as an index) when the FieldStorage instance is created.
> Mike Looijmans has been investigating StringField and Field as well. It is probably reasonable to include information on his work in this issue as well, so that we can consider all of these efficiency issues in toto.
|