| Craig L Russell 2005-11-28, 5:54 pm |
| Hi Michael,
Test class DeleteQueryElements has INVALID_QUERIES for which the
comments are incorrect. They should all start with "The query is
invalid because...". I suspect that you copied some of these from
other query tests, but there are more requirements for delete.
For example, I suggest changing "The query may fail because there is
a grouping clause, or because there is a grouping clause w/o result"
to "The query is invalid because there is a grouping clause".
I'd also suggest making two test cases from the test case"The query
may fail because there is a result, or because there is a result
class". These sound like different cases.
I notice in QueryTest that the execute method always starts a
transaction. Are there any tests that query outside a transaction?
Thanks,
Craig
On Nov 28, 2005, at 5:08 AM, Michael Watzek (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/JDO-166?page=all ]
>
> Michael Watzek updated JDO-166:
> -------------------------------
>
> Attachment: JDO-166.patch2
>
> The second patch implements the comments above.
>
>
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators:
> http://issues.apache.org/jira/secur...nistrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
|