|
Home > Archive > Apache JDO Project > July 2005 > TCK : updates required
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
TCK : updates required
|
|
| Andy Jefferson 2005-07-25, 5:45 pm |
| A few things that need fixing in the TCK from my latest running, in the hope
that someone with SVN permissions can do the necessary. No patches here, just
instructions of what's wrong and what is needed to fix ;-)
File :
test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/CollectionCollections-derby.orm
Has a field
<field name="CollectionOfByte26" table="COLLECTION_OF_BYTE27">
I suggest that the column name should end with ... 26
File :
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/CollectionCollections-derby.orm
Same thing
-------
File :
test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/ArrayListCollections-derby.orm
Has a class
<class name="ArrayListCollections" table="LIST_COLLECTIONS">
I suggest that the table name should be ARRAYLIST_COLLECTIONS
File :
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/ArrayListCollections-derby.orm
Same thing
-------
File :
test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/MapStringKeyCollections-derby.orm
Has a field
<field name="MapOfString_Byte26" column="MAP_OF_STRING_BYTE27">
I suggest that the column name should end with ... 26
File :
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/MapStringKeyCollections-derby.orm
Same thing
-------
File :
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/HashMapStringKeyCollections-derby.orm
Has a field
<field name="HashMapOfString_Long80" column="HASHMAP_STR_LONG80">
which doesnt exist in the Java class. Suggest that you remove it.
-------
There were several others of a similar nature in the various
collection/list/map tests but that's as far as I've got.
--
Andy
| |
| Michelle Caisse 2005-07-25, 5:45 pm |
| Hi Andy,
Thanks for the problem report. I've fixed these and checked them in.
If you find more, please let me know. I think these tests are hitting
problems before they reveal my typos, so they are hard for me to find.
-- Michelle
Andy Jefferson wrote:
>A few things that need fixing in the TCK from my latest running, in the hope
>that someone with SVN permissions can do the necessary. No patches here, just
>instructions of what's wrong and what is needed to fix ;-)
>
>
>File :
>test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/CollectionCollections-derby.orm
>Has a field
><field name="CollectionOfByte26" table="COLLECTION_OF_BYTE27">
>I suggest that the column name should end with ... 26
>
>File :
>test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/CollectionCollections-derby.orm
>Same thing
>
>-------
>
>File :
>test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/ArrayListCollections-derby.orm
>Has a class
><class name="ArrayListCollections" table="LIST_COLLECTIONS">
>I suggest that the table name should be ARRAYLIST_COLLECTIONS
>
>File :
>test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/ArrayListCollections-derby.orm
>Same thing
>
>-------
>
>File :
>test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/MapStringKeyCollections-derby.orm
>Has a field
><field name="MapOfString_Byte26" column="MAP_OF_STRING_BYTE27">
>I suggest that the column name should end with ... 26
>
>File :
>test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/MapStringKeyCollections-derby.orm
>Same thing
>
>-------
>
>File :
>test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/HashMapStringKeyCollections-derby.orm
>Has a field
><field name="HashMapOfString_Long80" column="HASHMAP_STR_LONG80">
>which doesnt exist in the Java class. Suggest that you remove it.
>
>-------
>
>
>
>There were several others of a similar nature in the various
>collection/list/map tests but that's as far as I've got.
>
>
>
| |
| Andy Jefferson 2005-07-26, 7:45 am |
| Hi Michelle,
> Thanks for the problem report. I've fixed these and checked them in.
Thanks.
> If you find more, please let me know. I think these tests are hitting
> problems before they reveal my typos, so they are hard for me to find.
I agree - which is why I thought it would be more efficient for me to run
through them and eliminate the obvious JPOX and TCK issues until we get to a
point that JPOX does what i'd expect, and there's something for you to look
at.
Here's the next batch
------------------------ applicationidentity ----------------------------
File:
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/ArrayListCollections-derby.orm
Has <class name="ArrayListCollections" table="LIST_COLLECTIONS">
The table should be ARRAYLIST_COLLECTIONS
Has <field name="ArrayListOfByte26" table="ARRAYLIST_OF_BYTE27">
The table should be ARRAYLIST_OF_BYTE26
-----
File:
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/HashMapStringKeyCollections-derby.orm
Has <field name="HashMapOfString_Byte26" column="HASHMAP_STR_BYTE27">
The column should be HASHMAP_STR_BYTE26
-----
File:
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/HashSetCollections-derby.orm
Has <field name="HashSetOfBigDecimal19" column="HASHSET_OF_BIG_DECIMAL18">
The column should be HASHSET_OF_BIG_DECIMAL19
Has <field name="HashSetOfByte26" table="HASHSET_OF_BYTE27">
The table should be HASHSET_OF_BYTE26
-----
File:
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/LinkedListCollections-derby.orm
Has <field name="LinkedListOfByte26" table="LINKEDLIST_OF_BYTE27">
The table should be LINKEDLIST_OF_BYTE26
-----
File:
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/ListCollections-derby.orm
Has <field name="ListOfByte26" table="LIST_OF_BYTE27">
The table should be LIST_OF_BYTE26
-----
File:
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/SetCollections-derby.orm
Has <field name="SetOfBigDecimal19" column="SET_OF_BIG_DECIMAL18">
The column should be SET_OF_BIG_DECIMAL19
Has <field name="SetOfByte26" table="SET_OF_BYTE27">
The table should be SET_OF_BYTE26
-----
File:
test/orm/applicationidentity/org/apache/jdo/tck/pc/fieldtypes/VectorCollections-derby.orm
Has <field name="VectorOfByte26" table="VECTOR_OF_BYTE27">
The table should be VECTOR_OF_BYTE26
-----
File: test/sql/applicationidentity/schema.sql
seems to be missing a table "LIST_OF_BYTE24" (referred to in the metadata, and
there are tables ARRAYLIST_OF_BYTE24, etc)
------------------------ datastoreidentity ----------------------------
File:
test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/ArrayListCollections-derby.orm
Has <field name="ArrayListOfByte26" table="ARRAYLIST_OF_BYTE27">
The table should be ARRAYLIST_OF_BYTE26
-----
File:
test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/HashSetCollections-derby.orm
Has <field name="HashSetOfBigDecimal19" column="HASHSET_OF_BIG_DECIMAL18">
The column should be HASHSET_OF_BIG_DECIMAL19
Has <field name="HashSetOfByte26" table="HASHSET_OF_BYTE27">
The table should be HASHSET_OF_BYTE26
-----
File:
test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/LinkedListCollections-derby.orm
Has <field name="LinkedListOfByte26" table="LINKEDLIST_OF_BYTE27">
The table should be LINKEDLIST_OF_BYTE26
-----
File:
test/orm/datastoreidentity/org/apache/jdo/tck/pc/fieldtypes/ListCollections-derby.orm
Has <field name="ListOfByte26" table="LIST_OF_BYTE27">
The table should be LIST_OF_BYTE26
-----
File:
test/orm/datastorenidentity/org/apache/jdo/tck/pc/fieldtypes/SetCollections-derby.orm
Has <field name="SetOfBigDecimal19" column="SET_OF_BIG_DECIMAL18">
The column should be SET_OF_BIG_DECIMAL19
Has <field name="SetOfByte26" table="SET_OF_BYTE27">
The table should be SET_OF_BYTE26
-----
File:
test/orm/datastorenidentity/org/apache/jdo/tck/pc/fieldtypes/VectorCollections-derby.orm
Has <field name="VectorOfByte26" table="VECTOR_OF_BYTE27">
The table should be VECTOR_OF_BYTE26
If you get the next JPOX build from http://www.jpox.org/downloads/nightly/
things should progress much further (certainly on the Collection/Set/List
derived cases) - getting to errors thrown by Derby about a double being
outside the range of what it accepts.
I'll look at the Map cases next
--
Andy
| |
| Andy Jefferson 2005-07-26, 7:45 am |
| > I'll look at the Map cases next
Michelle,
Here's some initial comments on the map tests.
1. HashMapStringKeyCollections : Field "HashMapOfString_SimpleInterface7" is a
Map<String,Interface> with the value embedded, and no join table. I interpret
that as needing to serialise the map into the main table, but unfortunately
there's no column for it in the schema (even though the column name is
defined)
2. HashMapStringValueCollections : Field "HashMapOfBigDecimal_String53" is a
Map<BigDecimal,String> with a join table, and the value is defined to use a
column with name "STRING". The schema for the join table
"HASHMAP_BIG_DECIMAL53_STR" has no column called STRING - its called VALUEVAL
in that case. Either the schema or the ORM need changing to match.
Now these general observations apply to the other map tests too, and to other
fields in the same classes.
--
Andy
Java Persistent Objects - JPOX
| |
| Michelle Caisse 2005-07-26, 5:45 pm |
| Hi Andy,
I checked in all these fixes and then some. I also added the
serialized="true" tag where needed (JDO-82).
-- Michelle
Andy Jefferson wrote:
>
>Michelle,
>
>Here's some initial comments on the map tests.
>1. HashMapStringKeyCollections : Field "HashMapOfString_SimpleInterface7" is a
>Map<String,Interface> with the value embedded, and no join table. I interpret
>that as needing to serialise the map into the main table, but unfortunately
>there's no column for it in the schema (even though the column name is
>defined)
>
>2. HashMapStringValueCollections : Field "HashMapOfBigDecimal_String53" is a
>Map<BigDecimal,String> with a join table, and the value is defined to use a
>column with name "STRING". The schema for the join table
>"HASHMAP_BIG_DECIMAL53_STR" has no column called STRING - its called VALUEVAL
>in that case. Either the schema or the ORM need changing to match.
>
>
>Now these general observations apply to the other map tests too, and to other
>fields in the same classes.
>
>
>
>
|
|
|
|
|