|
Home > Archive > Apache JDO Project > September 2005 > Re: Please review this patch for PersistenceCapable, FetchPlan, JDOImplHelper
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
Re: Please review this patch for PersistenceCapable, FetchPlan, JDOImplHelper
|
|
| Michael Bouschen 2005-09-13, 7:45 am |
| Hi Craig,
another remark about FetchPlan.java: there is a typo in the javadoc for
the static fields DETACH_UNLOAD_FIELDS and DETACH_LOAD_FIELDS. They
should link to the PM method detachCopy instead of detach.
Regards Michael
> Hi Craig,
>
> here are my comments.
>
> PersistenceCapable and JDOImplHelper:
>
> - The javadoc uses class ObjectIdFieldProvider instead of
> ObjectIdFieldSupplier.
> - You might want to enclose the type Character in <code></code>.
> - The javadoc includes Character in the list of types for which the
> behavious is specified (because Character does not extend Number).
> The spec just mentions Number, ObjectIdFieldSupplier and String, but not
> Character (see section 7.12 JDO identity handling on page 78 of the PFD
> version of the spec).
>
> FetchPlan:
>
> - Minor: please add a newline at the end of the file.
>
> Regards Michael
>
>
>
>
--
Michael Bouschen Tech@Spree Engineering GmbH
mailto:mbo.tech@spree.de http://www.tech.spree.de/
Tel.:++49/30/235 520-33 Buelowstr. 66
Fax.:++49/30/2175 2012 D-10783 Berlin
|
|
|
|
|