|
Home > Archive > Apache JDO Project > October 2006 > setUp() not final in org.apache.jdo.tck.JDO_Test
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
setUp() not final in org.apache.jdo.tck.JDO_Test
|
|
| Michelle Caisse 2006-10-11, 1:11 pm |
| Hi,
I noticed that in JDO_Test, while tearDown() is declared final, setUp()
is not. The javadoc says subclasses may override localSetUp() and
localTearDown(). Is it a bug that setUp() is not declared final?
-- Michelle
| |
| Craig L Russell 2006-10-11, 7:11 pm |
| | |
| Michelle Caisse 2006-10-11, 7:11 pm |
| A number of tests do override it. Should I file a JIRA to fix all of this?
java:compile:
[echo] Compiling to c:\svn0\jdo\trunk\tck20/target/classes
[javac] Compiling 660 source files to
C:\svn0\jdo\trunk\tck20\target\classes
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\GetPersistenceManager.java:54:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden
method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\GetPersistenceManagerFactoryByProperti
esInstance.java:60:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory. GetPersistenceManagerFactoryByProperties
Instance
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden
method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\GetPersistenceManagerForUser.java:63:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden
method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetConnectionPassword.java:54:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionPassword
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden
method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetConnectionURL.java:58:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionURL cannot
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetConnectionUserName.java:57:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionUserName
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden
method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetIgnoreCache.java:53:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetIgnoreCache cannot
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetMultithreaded.java:57:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetMultithreaded cannot
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetNonTransactionalRead.java:54:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalRead
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden
method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetNonTransactionalWrite.java:54:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalWrite
cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden
method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetOptimistic.java:53:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetOptimistic cannot
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
protected void setUp() throws Exception {
^
C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetRetainValues.java:55:
setUp() in
org.apache.jdo.tck.api.persistencemanagerfactory.SetRetainValues cannot
override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
protected void setUp() throws Exception {
^
-- Michelle
Craig L Russell wrote:
> Hi Michelle,
>
> I think it's a bug. It might lead to some non-trivial issues if setUp
> is overridden instead of using localSetUp. Could you try making it
> final and see if there are some tests that override it?
>
> Craig
>
> On Oct 11, 2006, at 10:57 AM, Michelle Caisse wrote:
>
>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
| |
| Craig L Russell 2006-10-11, 7:11 pm |
| | |
| Michael Watzek 2006-10-12, 7:11 am |
| Hi Michelle,
I agree with Craig. It's a bug. The same holds true for method
JDO_Test.runBare(). I should be declared final as well.
Regards,
Michael
Craig L Russell schrieb:
> Hi Michelle,
>
> I think it's a bug. It might lead to some non-trivial issues if setUp is
> overridden instead of using localSetUp. Could you try making it final
> and see if there are some tests that override it?
>
> Craig
>
> On Oct 11, 2006, at 10:57 AM, Michelle Caisse wrote:
>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
--
-------------------------------------------------------------------
Michael Watzek Tech@Spree Engineering GmbH
mailto:mwa.tech@spree.de Buelowstr. 66
Tel.: ++49/30/235 520 36 10783 Berlin - Germany
Fax.: ++49/30/217 520 12 http://www.spree.de/
-------------------------------------------------------------------
| |
| Michelle Caisse 2006-10-12, 1:11 pm |
| Thanks, Michael. I will add that information to the JIRA issue.
-- Michelle
Michael Watzek wrote:
> Hi Michelle,
>
> I agree with Craig. It's a bug. The same holds true for method
> JDO_Test.runBare(). I should be declared final as well.
>
> Regards,
> Michael
>
> Craig L Russell schrieb:
>
>
>
|
|
|
|
|