| Michael Bouschen (JIRA) 2006-04-30, 7:11 pm |
| [ http://issues.apache.org/jira/brows...action_12377183 ]
Michael Bouschen commented on JDO-377:
--------------------------------------
The patch looks good! Please note, the CompletenessTest changes and the tearDownList modifications are already checked in as as part of JDO-375.
About the new test class LifecycleCompleteness.java:
I vote for adding this new new test class. Maybe we can add three new configurations: one for each CompanyFactory implementation (CompanyFactoryPMInterface, CompanyFactoryPMClass, CompanyFactoryConcreteClass). Please remove the last method in comments, it
seems to be outdated.
What do the others think?
> Company model factory improvements to test persistent interfaces
> ----------------------------------------------------------------
>
> Key: JDO-377
> URL: http://issues.apache.org/jira/browse/JDO-377
> Project: JDO
> Type: Improvement
> Components: tck20
> Versions: JDO 2 rc1
> Reporter: Craig Russell
> Priority: Minor
> Fix For: JDO 2 final
> Attachments: JDO-377.patch, LifecycleCompleteness.java, lifecyclecompleteness.conf
>
> Please review this patch.
> In order to test persistent interfaces better, a method was added to the CompanyFactory interface to allow the test program to get the persistent instances.
> List getAllInstances();
> To implement this new API, changes were made to the factory implementation classes to keep track of instances as they were created.
> Additionally, only classes (or interfaces) actually instantiated were put into the tearDown class array. So Person.class and Employee.class were removed from the array.
> Finally, a bug was fixed in CompanyFactoryPMClass where the interface IMedicalInsurance.class was incorrectly added to the tearDown class array.
> A new test class was used for testing. This class might be added to the TCK if suitable.
> And a new configuration was used for testing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|