| Michelle Caisse (JIRA) 2007-05-21, 1:11 pm |
|
[ https://issues.apache.org/jira/brow...action_12497512 ]
Michelle Caisse commented on JDO-433:
-------------------------------------
If we don't closePMF, the call to getUnconfiguredPMF() returns the standard PMF that is created by the setUp() method in the parent class before its call to localSetUp(). It seems to me that getUnconfiguredPMF() should either throw an exception or close
the existing pmf itself if pmf is not null, rather than returning something which the caller may not want.
> setUp() is not declared final in org.apache.jdo.tck.JDO_Test
> ------------------------------------------------------------
>
> Key: JDO-433
> URL: https://issues.apache.org/jira/browse/JDO-433
> Project: JDO
> Issue Type: Bug
> Components: tck2
> Affects Versions: JDO 2 final
> Reporter: Michelle Caisse
> Assigned To: Michelle Caisse
> Priority: Minor
> Fix For: JDO 2 maintenance release 1
>
> Attachments: JDO-433.patch
>
>
> Tests are to override localSetUp() for test specific set up. The setUp() method in JDO_Test is not meant to be overriden. However, it is not currently declared to be final. It should be declared final and the set up code in the tests that do override
setUp() (listed below) should be in localSetUp().
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\GetPersistenceManager.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManager cannot override setUp() in org.apache.jdo.tck.JDO_Test; ov
erridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\GetPersistenceManagerFactoryByProperti
esInstance.java:60: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory. GetPersistenceManagerFactoryByProperties
Instance cann
ot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\GetPersistenceManagerForUser.java:63: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.GetPersistenceManagerForUser cannot override setUp() in org.apache.jdo.tc
k.JDO_Test; overridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetConnectionPassword.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionPassword cannot override setUp() in org.apache.jdo.tck.JDO_Test; ov
erridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetConnectionURL.java:58: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionURL cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden m
ethod is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetConnectionUserName.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetConnectionUserName cannot override setUp() in org.apache.jdo.tck.JDO_Test; ov
erridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetIgnoreCache.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetIgnoreCache cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden metho
d is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetMultithreaded.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetMultithreaded cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden m
ethod is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetNonTransactionalRead.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalRead cannot override setUp() in org.apache.jdo.tck.JDO_Test
; overridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetNonTransactionalWrite.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetNonTransactionalWrite cannot override setUp() in org.apache.jdo.tck.JDO_T
est; overridden method is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetOptimistic.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetOptimistic cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method
is final
> protected void setUp() throws Exception {
> ^
> C:\svn0\jdo\trunk\tck20\src\java\org\apa
che\jdo\tck\api\persistencemanagerfactor
y\SetRetainValues.java:55: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.SetRetainValues cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden met
hod is final
> protected void setUp() throws Exception {
> ^
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|