| Trustin Lee (JIRA) 2005-11-28, 5:54 pm |
| [ http://issues.apache.org/jira/brows...NA-131?page=all ]
Trustin Lee updated DIRMINA-131:
--------------------------------
Description:
This issue is the summary of these threads in the Apache Directory Project mailing list:
http://www.nabble.com/-mina-Refacto...29-t553121.html
http://www.nabble.com/-mina-IoFilte...22-t548297.html
Currently, IoFilterChains are categorized into two; one is IoSessionManagerFilterChain, and the other is IoSessionFilterChain. IoSessionManagerFilterChain is shared by all sessions managed by the same IoSessionManager, and IoSessionFilterChain is individ
ual for each session. But this design made the internal architecture of MINA filter chain very complex comparing its usefulness.
What about just getting rid of the original IoSessionManagerFilterChain, and provide a simple data structure which just stores a list of filters but still implements IoFilter interface? By doing so, we can simply copy the chain into the IoSessionFilterCh
ain before we start the communication, so the chain implementation gets simplified dramatically.
Besides that, we have another option instead of using a simple data structure that implements IoFilterChain. It is called 'IoFilterChainBuilder'. It is a kind of command pattern which configures the filter chain instead of simply appending the filter li
st the chain. It provides great flexibility. For example, you can override the settings of per-manager filter chain in your per-port (or per-session) chain builder.
I think it will be best if we can combine these two approach by providing an IoFilterChainBuilder implementation which simply appends the specified filter list to the per-session chain.
was:
Currently, IoFilterChains are categorized into two; one is IoSessionManagerFilterChain, and the other is IoSessionFilterChain. IoSessionManagerFilterChain is shared by all sessions managed by the same IoSessionManager, and IoSessionFilterChain is individ
ual for each session. But this design made the internal architecture of MINA filter chain very complex comparing its usefulness.
What about just getting rid of the original IoSessionManagerFilterChain, and provide a simple data structure which just stores a list of filters but still implements IoFilter interface? By doing so, we can simply copy the chain into the IoSessionFilterCh
ain before we start the communication, so the chain implementation gets simplified dramatically.
Besides that, we have another option instead of using a simple data structure that implements IoFilterChain. It is called 'IoFilterChainBuilder'. It is a kind of command pattern which configures the filter chain instead of simply appending the filter li
st the chain. It provides great flexibility. For example, you can override the settings of per-manager filter chain in your per-port (or per-session) chain builder.
I think it will be best if we can combine these two approach by providing an IoFilterChainBuilder implementation which simply appends the specified filter list to the per-session chain.
> Get rid of complexity of the current IoFilterChain.
> ---------------------------------------------------
>
> Key: DIRMINA-131
> URL: http://issues.apache.org/jira/browse/DIRMINA-131
> Project: Directory MINA
> Type: Improvement
> Versions: 0.8
> Reporter: Trustin Lee
> Assignee: Trustin Lee
> Fix For: 0.9
>
> This issue is the summary of these threads in the Apache Directory Project mailing list:
> http://www.nabble.com/-mina-Refacto...29-t553121.html
> http://www.nabble.com/-mina-IoFilte...22-t548297.html
> Currently, IoFilterChains are categorized into two; one is IoSessionManagerFilterChain, and the other is IoSessionFilterChain. IoSessionManagerFilterChain is shared by all sessions managed by the same IoSessionManager, and IoSessionFilterChain is indiv
idual for each session. But this design made the internal architecture of MINA filter chain very complex comparing its usefulness.
> What about just getting rid of the original IoSessionManagerFilterChain, and provide a simple data structure which just stores a list of filters but still implements IoFilter interface? By doing so, we can simply copy the chain into the IoSessionFilter
Chain before we start the communication, so the chain implementation gets simplified dramatically.
> Besides that, we have another option instead of using a simple data structure that implements IoFilterChain. It is called 'IoFilterChainBuilder'. It is a kind of command pattern which configures the filter chain instead of simply appending the filter
list the chain. It provides great flexibility. For example, you can override the settings of per-manager filter chain in your per-port (or per-session) chain builder.
> I think it will be best if we can combine these two approach by providing an IoFilterChainBuilder implementation which simply appends the specified filter list to the per-session chain.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|