| Nick Faiz (JIRA) 2005-06-26, 8:45 pm |
| [ http://issues.apache.org/jira/brows...action_12314520 ]
Nick Faiz commented on DIREVE-171:
----------------------------------
Hi Emmanuel,
Good idea! Thanks for making me not be lazy. 
There seems to be a logical inconsistency between the MainFrame class, which uses FilterDialog's own logging settings and the standard log4j logging levels.
After applying the changes you recommended we run into a scenario where the MainFrame is dumping some of its own logging information, depending on how a setting in a GUI somewhere (I think).
Anyway, see line 531 of MainFrame.class. This is what I ended up doing:
else if ( mode == FilterDialog.DEBUG_MODE )
{
if (DEBUG)
{
log.debug( "Search attempt using filter '" + dialog.getFilter() + "' "
+ "with scope '" + dialog.getScope() + "' and a return limit of '"
+ dialog.getLimit() + "'" );
}
else //it would seem we need to make a debug statement, based on a program instruction
{ //which differs to the log4j priority.
//in this circumstance we simply use the old System printwriter for stdout.
System.out.println( "Search attempt using filter '" + dialog.getFilter() + "' "
+ "with scope '" + dialog.getScope() + "' and a return limit of '"
+ dialog.getLimit() + "'" );
}
}
I guess Id ask the question - should the FilterDialog decide anything about logging levels?
Cheers,
Nick
> add log4j config patch
> ----------------------
>
> Key: DIREVE-171
> URL: http://issues.apache.org/jira/browse/DIREVE-171
> Project: Directory Server
> Type: Improvement
> Components: server main
> Versions: 0.9.1
> Reporter: Nick Faiz
> Assignee: Alex Karasulu
> Priority: Trivial
> Attachments: log4j.properties, log_patch2.txt, logging_patch.txt
>
> Please find enclosed a patch (diff file) and a log4j.properties file.
> You should create a src/etc directory for main and core and place the properties file there.
> Cheers,
> Nick
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|