| Emmanuel Lecharny (JIRA) 2005-06-27, 2:45 am |
| [ http://issues.apache.org/jira/brows...action_12314523 ]
Emmanuel Lecharny commented on DIREVE-171:
------------------------------------------
Hi Nick,
in MainFrame.class, I think that keeping the code this way should be enough :
... else if ( mode == FilterDialog.DEBUG_MODE )
{
log.debug( "Search attempt using filter '" + dialog.getFilter() + "' "
+ "with scope '" + dialog.getScope() + "' and a return limit of '"
+ dialog.getLimit() + "'" );
}
You already have a test on the level, so do not care about the string being built.
Anyway, yes, I think there is an inconstency about debug level used in log4j and FilterDialog.
Be aware that the little optimization I suggested is better suited for server side, not for GUI. So use it when you think it fits your need. Personnaly, I found it confortable to use it everywhere, because it don't arm (except when you want to switch to
debug dynamically).
About your last question, I don't know. This is up to you to decide if it should !
Keep up the good job ! We need guys like you working on those pieces of code !
> add log4j config patch
> ----------------------
>
> Key: DIREVE-171
> URL: http://issues.apache.org/jira/browse/DIREVE-171
> Project: Directory Server
> Type: Improvement
> Components: server main
> Versions: 0.9.1
> Reporter: Nick Faiz
> Assignee: Alex Karasulu
> Priority: Trivial
> Attachments: log4j.properties, log_patch2.txt, logging_patch.txt
>
> Please find enclosed a patch (diff file) and a log4j.properties file.
> You should create a src/etc directory for main and core and place the properties file there.
> Cheers,
> Nick
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|