|
Home > Archive > Apache Directory Project > July 2005 > [jira] Commented: (DIREVE-171) add log4j config patch
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
[jira] Commented: (DIREVE-171) add log4j config patch
|
|
| Ceki Gulcu (JIRA) 2005-07-26, 7:45 am |
| [ http://issues.apache.org/jira/brows...action_12316730 ]
Ceki Gulcu commented on DIREVE-171:
-----------------------------------
Nick,
I appreciate your work on setting up nlog4j at ibiblio. Thank you.
You might want to consider using format patterns as described in [1, 2].
Just to let you know an alternative exists,
[1] http://www.slf4j.org/manual.html (see section "Typical usage pattern")
[2] http://www.slf4j.org/faq.html#2.3
Cheers,
> add log4j config patch
> ----------------------
>
> Key: DIREVE-171
> URL: http://issues.apache.org/jira/browse/DIREVE-171
> Project: Directory Server
> Type: Improvement
> Components: server main
> Versions: 0.9.1
> Reporter: Nick Faiz
> Assignee: Alex Karasulu
> Priority: Trivial
> Attachments: log4j.properties, log_patch2.txt, logging_patch.txt, logging_patch_3.txt
>
> Please find enclosed a patch (diff file) and a log4j.properties file.
> You should create a src/etc directory for main and core and place the properties file there.
> Cheers,
> Nick
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
| |
| Nick Faiz 2005-07-26, 7:45 am |
| Hi Ceki,
=20
Yes, that sounds like a good idea.=20
Right now, imo, the main issue is to get the logging configuration in
place - as a dependency in project.xml for apacheds, so people can use
it. Afterwards, the pattern layout can change, the logging statements
can be altered.
The 'Better alternative based on format messages' in
http://www.slf4j.org/faq.html#2.3 looks really good.
Cheers,
Nick
On 7/26/05, Ceki Gulcu (JIRA) <directory-dev-d1GL8uUpDdXTxqt0kkDzDmD2FQJk+8+b@public.gmane.org> wrote:
> [ http://issues.apache.org/jira/brows...3Dcomments#act=
ion_12316730 ]
>=20
> Ceki Gulcu commented on DIREVE-171:
> -----------------------------------
>=20
> Nick,
>=20
> I appreciate your work on setting up nlog4j at ibiblio. Thank you.
>=20
> You might want to consider using format patterns as described in [1, 2].
> Just to let you know an alternative exists,
>=20
> [1] http://www.slf4j.org/manual.html (see section "Typical usage pattern=
")
> [2] http://www.slf4j.org/faq.html#2.3
>=20
> Cheers,
>=20
ing_patch_3.txt[vbcol=seagreen]
roperties file there.[vbcol=seagreen]
>=20
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secur...nistrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>=20
>
| |
| Ceki Gülcü 2005-07-26, 7:45 am |
|
Hi Nick,
I might be completely off base in this particular case, but in
general, a library-type component should NOT configure log4j and let
the user do it. Of course, you can still document logging in your
library, in particular by providing one or more sample configuration
files. The point is that you should not *impose* a log4j config file
on the end-user.
In the case of application (and not a library), you can provide a
default log4j configuration file, but you should be careful to allow
the end-user change it if she wants to.
As basic rule of thumb, you should view logging mostly as an end-user
concern. I hope these general remarks are helpful to you rather than a
distraction,
At 12:55 PM 7/26/2005, Nick Faiz wrote:
>Hi Ceki,
>
>Yes, that sounds like a good idea.
>
>Right now, imo, the main issue is to get the logging configuration in
>place - as a dependency in project.xml for apacheds, so people can use
>it. Afterwards, the pattern layout can change, the logging statements
>can be altered.
>
>The 'Better alternative based on format messages' in
>http://www.slf4j.org/faq.html#2.3 looks really good.
>
>Cheers,
>Nick
--=20
Ceki G=FClc=FC
The complete log4j manual: http://www.qos.ch/log4j/
| |
| Nick Faiz 2005-07-26, 5:45 pm |
| Hi Ceki,
=20
Thanks for paying attention to our use of slf4j. I agree with you.
Please remember, though, that this is just a patch which provides one
thing - a configuration for slf4j which works for development.
The patch attached to DIREVE171 is a simple step forward - it is not
the entire logging picture. So far it's taken 5 weeks to apply this
one, small thing. I want to get it through before raising further
logging ideas, which could take more time.
Further work on logging will occur in subsequent patches, however, and
I'll be discussing it with the list. If you would be interested in
providing feedback then I would obviously welcome it.
Cheers,
Nick=20
On 7/26/05, Ceki G=FClc=FC <listid-vdLmLxQ6Fys@public.gmane.org> wrote:
>=20
> Hi Nick,
>=20
> I might be completely off base in this particular case, but in
> general, a library-type component should NOT configure log4j and let
> the user do it. Of course, you can still document logging in your
> library, in particular by providing one or more sample configuration
> files. The point is that you should not *impose* a log4j config file
> on the end-user.
>=20
> In the case of application (and not a library), you can provide a
> default log4j configuration file, but you should be careful to allow
> the end-user change it if she wants to.
>=20
> As basic rule of thumb, you should view logging mostly as an end-user
> concern. I hope these general remarks are helpful to you rather than a
> distraction,
>=20
>=20
> At 12:55 PM 7/26/2005, Nick Faiz wrote:
>=20
> --
> Ceki G=FClc=FC
>=20
> The complete log4j manual: http://www.qos.ch/log4j/
>=20
>=20
>
| |
| Nick Faiz 2005-07-26, 8:45 pm |
|
Actually, to make things transparent I will create a logging plan page,
on the wiki, outlining the ideas I have in mind and asking for feedback
from others, including best usages (such as log.debug("hello {}",
getName()) ), etc.. I'll post a list to the URL when it's there.
Hopefully, this will make things clearer. I'll use the project's wiki.
Cheers,
Nick
Nick Faiz wrote:
> Hi Ceki,
>
> Thanks for paying attention to our use of slf4j. I agree with you.
> Please remember, though, that this is just a patch which provides one
> thing - a configuration for slf4j which works for development.
>
> The patch attached to DIREVE171 is a simple step forward - it is not
> the entire logging picture. So far it's taken 5 weeks to apply this
> one, small thing. I want to get it through before raising further
> logging ideas, which could take more time.
>
> Further work on logging will occur in subsequent patches, however, and
> I'll be discussing it with the list. If you would be interested in
> providing feedback then I would obviously welcome it.
>
> Cheers,
> Nick
>
>
>
>
> On 7/26/05, Ceki Gülcü <listid-vdLmLxQ6Fys@public.gmane.org> wrote:
>
>
>
--
ATLASSIAN - http://www.atlassian.com/
Confluence - the enterprise wiki - tried it yet?
http://www.atlassian.com/confluence/
--
| |
| Nick Faiz 2005-07-27, 5:45 pm |
| All,
Here's the URL I mentioned - http://wiki.apache.org/directory/LoggingPlan=
=20
I'll go ahead and start doing this - if someone has feedback please let me =
know.
Cheers,
Nick
=20
On 7/27/05, Nick Faiz <nick-YrDk4eUcT3KaMJb+Lgu22Q@public.gmane.org> wrote:
>=20
> Actually, to make things transparent I will create a logging plan page,
> on the wiki, outlining the ideas I have in mind and asking for feedback
> from others, including best usages (such as log.debug("hello {}",
> getName()) ), etc.. I'll post a list to the URL when it's there.
>=20
> Hopefully, this will make things clearer. I'll use the project's wiki.
>=20
> Cheers,
> Nick
>=20
>=20
> Nick Faiz wrote:
>=20
>=20
> --
> ATLASSIAN - http://www.atlassian.com/
>=20
> Confluence - the enterprise wiki - tried it yet?
> http://www.atlassian.com/confluence/
> --
>
|
|
|
|
|