| Norbert Reilly (JIRA) 2006-06-26, 7:11 am |
| [ http://issues.apache.org/jira/brows...action_12417745 ]
Norbert Reilly commented on DIRSERVER-619:
------------------------------------------
On further investigation e.getMessage() would be better replaced by e.toString() which includes information about the root cause, if one has been set.
> NamingException messages are thrown away by MessageHandlers
> -----------------------------------------------------------
>
> Key: DIRSERVER-619
> URL: http://issues.apache.org/jira/browse/DIRSERVER-619
> Project: Directory ApacheDS
> Type: Bug
> Components: ldap
> Versions: 1.0-RC3
> Environment: N/A
> Reporter: Norbert Reilly
> Attachments: handler_exception_msgs_at_397393.patch
>
> The LDAP MessageHandlers (e.g. org.apache.directory.server.ldap.support.AddHandler) throw away the messages attached to caught NamingExceptions before rethrowing their own newly created exceptions:
> catch ( NamingException e )
> {
> String msg = "failed to add entry " + req.getEntry();
> if ( log.isDebugEnabled() )
> {
> msg += ":\n" + ExceptionUtils.getStackTrace( e );
> }
> where I would like to see
> catch ( NamingException e )
> {
> String msg = "failed to add entry " + req.getEntry() + ": " + e.getMessage();
> instead. Without this fix all meaningful details about the problem are thrown away and can not be displayed in the LDAP client meaning that server log files have to be inspected immediately.
> In addition, this seems like a simple oversight as even in the debugging case only the server stacktrace is merged into the exception message and hence sent to the client where the original NamingException message is much more valuable for debugging the
n the stacktrace alone.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|