| Matthew Hawkins 2004-06-29, 8:46 pm |
| Piotr Roszatycki (Piotr_Roszatycki@netia.net.pl) wrote:
> The config.inc.php is no more a configuration file!
I have to disagree. My justification:
Your NEWS.Debian.gz notes:
--- snip ---
phpmyadmin (1:2.5.7-1) unstable; urgency=low
The configuration is splitted to the /etc/phpmyadmin/config.inc.php
and /usr/share/phpmyadmin/config.inc.php files.
--- snip ---
phpMyAdmin's own Documentation.html reads:
--- snip ---
Configuration
Warning for Mac users: php seems not to like Mac end of lines character
("\r"). So ensure you choose the option that allows to use
the *nix end of line character ("\n") in your text editor before
registering a script you have modified.
All configurable data is placed in config.inc.php.
--- snip ---
So both upstream and yourself disagree with you ;-)
> This is php source file and should be placed at /usr/share hierarchy.
Yeah yeah and /etc/init.d/* are shell source files that belong in /sbin
not /etc. You know, I don't see anywhere where section 10.7.2 dictates
a specific format for a configuration file. It's completely irrelevent
whether it's plain text, CSV, config.ini, some language like PHP. It's
still a configuration file. And in this case, according to the upstream
documentation, THE configuration file.
> The original config.inc.php changes too much and 3-way diff tool is
> not a solution. I've got a lot of bug report because the user didn't
> upgrade this configuration file.
Having run phpmyadmin for 5-6 years I'm somewhat familiar with the
changes it has gone through. It's never been a problem before to "diff
config.inc.php config.inc.php.dpkg-dist" and merge any necessary
changes. And trust me, I've got a huge amount of changes including the
way the server list/config is generated (I array-ise the server list and
loop it rather than flat-listing each $cfg['Servers'] entry like
upstream ;) Its straight-forward, future-proof, and uses standard unix
tools (diff, vi) This is no longer possible with what you've done here.
I realise a 3-way diff tool is not an elegant solution but I'm open to
your suggestion as to how to maintain a working configuration under your
new config regime. I certainly hope /usr/share/phpmyadmin/config.inc.php
is still marked as a config file otherwise there'll be no way of telling
what options /etc/phpmyadmin/config.inc.php may be overriding should
upstream change (which you allude happens frequently)
--
Matt
|