|
Home > Archive > Debian Developers > September 2004 > don't close bugs without an explanation!
You are viewing an archived Text-only version of the thread.
To view this thread in it's original format and/or if you want to reply to
this thread please [click here]
| Author |
don't close bugs without an explanation!
|
|
| Joshua Kwan 2004-09-25, 5:55 pm |
| reopen 252772
reopen 188002
reopen 260144
stop closing bugs in changelogs with no explanation!
Ramakrishnan,
Closing bugs in changelogs without explanation is abusing the ability
to do so. Your latest cpuid upload had this:
cpuid (3.3-3) unstable; urgency=low
* (closes: #252772)
* (closes: #188002)
* (closes: #260144)
A proper changelog entry might say
cpuid (3.3-3) unstable; urgency=low
* Corrected upstream URL in copyright. (closes: #188002)
* Add amd64 and GNU/kFreeBSD support in control file.
(closes: #252772, #260144)
Without this, I have no way to find out - without visiting all three
bugs myself, or checking the delta between the source packages - what
happened between -2 and -3. Making descriptive changelogs makes life so
much easier for many people using and fixing bugs in/around the package.
Perhaps you should make another upload with a clearer changelog.
NB: You're also NMUing yourself, because you sign as Ramakrishnan
Muthukrishnan but the maintainer of the package is set to Ramakrishnan
M. Pick one.
Thanks
--
Joshua Kwan
| |
| Adam Heath 2004-09-25, 5:55 pm |
| On Sat, 25 Sep 2004, Joshua Kwan wrote:
> Perhaps you should make another upload with a clearer changelog.
No, this is wrong too. Uploads that don't actually change anything in the
package, just to have something in the changelog, are wrong as well.
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Brian Nelson 2004-09-25, 8:49 pm |
| On Sat, Sep 25, 2004 at 02:35:47PM -0500, Adam Heath wrote:
> On Sat, 25 Sep 2004, Joshua Kwan wrote:
>
>
> No, this is wrong too. Uploads that don't actually change anything in the
> package, just to have something in the changelog, are wrong as well.
I disagree. Documenting the changes made to a package is a very
important part of an upload.
--
Blast you and your estrogenical treachery!
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Adam Heath 2004-09-25, 8:49 pm |
| On Sat, 25 Sep 2004, Brian Nelson wrote:
> On Sat, Sep 25, 2004 at 02:35:47PM -0500, Adam Heath wrote:
>
> I disagree. Documenting the changes made to a package is a very
> important part of an upload.
Documenting changes made in previous upload is not, however.
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Steve Langasek 2004-09-25, 8:49 pm |
| On Sat, Sep 25, 2004 at 04:40:06PM -0700, Brian Nelson wrote:
> On Sat, Sep 25, 2004 at 02:35:47PM -0500, Adam Heath wrote:
[vbcol=seagreen]
> I disagree. Documenting the changes made to a package is a very
> important part of an upload.
That doesn't mean it's right to re-upload just to fix a changelog.
--
Steve Langasek
postmodern programmer
| |
| Colin Watson 2004-09-25, 8:49 pm |
| On Sat, Sep 25, 2004 at 04:40:06PM -0700, Brian Nelson wrote:
> On Sat, Sep 25, 2004 at 02:35:47PM -0500, Adam Heath wrote:
>
> I disagree. Documenting the changes made to a package is a very
> important part of an upload.
Fix the changelog in your local tree so that it properly documents the
real history of the package, but there's no need to upload until
something more important comes up.
--
Colin Watson [cjwatson@debian.org]
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Brian Nelson 2004-09-25, 8:49 pm |
| On Sun, Sep 26, 2004 at 01:22:38AM +0100, Colin Watson wrote:
> On Sat, Sep 25, 2004 at 04:40:06PM -0700, Brian Nelson wrote:
>
> Fix the changelog in your local tree so that it properly documents the
> real history of the package, but there's no need to upload until
> something more important comes up.
So then the bug submitters never see the real reason the bug was closed,
apt-listchanges (presumably) suppresses the additions to the old
changelog entry so that anyone with the package installed never sees the
real entries... Plus, any maintainer clueless enough to write awful
changelog entries is very likely a negligent maintainer, and thus highly
unlikely to make an upload to fix "something more important" for many
months. Why is this an OK situation? Is this to work around gimped
architectures with broken autobuilders?
--
Blast you and your estrogenical treachery!
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Steve Langasek 2004-09-25, 8:49 pm |
| On Sat, Sep 25, 2004 at 06:43:21PM -0700, Brian Nelson wrote:
> On Sun, Sep 26, 2004 at 01:22:38AM +0100, Colin Watson wrote:
[vbcol=seagreen]
> So then the bug submitters never see the real reason the bug was closed,
> apt-listchanges (presumably) suppresses the additions to the old
> changelog entry so that anyone with the package installed never sees the
> real entries... Plus, any maintainer clueless enough to write awful
> changelog entries is very likely a negligent maintainer, and thus highly
> unlikely to make an upload to fix "something more important" for many
> months. Why is this an OK situation? Is this to work around gimped
> architectures with broken autobuilders?
The purpose of fixing the changelog is to *fix the changelog*, not to
notify the bug submitter for the reason for the closure.
The submitters should be notified of the reason for the closure
manually, by emailing -submitter. The maintainer has already screwed up
the use of the changelog bug-closing convenience; uploading another
package for no other reason than to be able to use this convenience
again is horribly broken.
--
Steve Langasek
postmodern programmer
| |
| Adam Heath 2004-09-25, 8:49 pm |
| On Sat, 25 Sep 2004, Steve Langasek wrote:
> The purpose of fixing the changelog is to *fix the changelog*, not to
> notify the bug submitter for the reason for the closure.
>
> The submitters should be notified of the reason for the closure
> manually, by emailing -submitter. The maintainer has already screwed up
> the use of the changelog bug-closing convenience; uploading another
> package for no other reason than to be able to use this convenience
> again is horribly broken.
2 wrongs don't make a right.
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Colin Watson 2004-09-26, 5:55 pm |
| On Sat, Sep 25, 2004 at 09:01:36PM -0500, Adam Heath wrote:
> On Sat, 25 Sep 2004, Steve Langasek wrote:
>
> 2 wrongs don't make a right.
Abusing the changelog to close the bug in the wrong version is a wrong;
so what's your point?
--
Colin Watson [cjwatson@debian.org]
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Thomas Viehmann 2004-09-26, 5:55 pm |
| Adam Heath wrote:
> 2 wrongs don't make a right.
Actually, there are right wrongs and wrong rights in addition to wrong
wrongs and right rights. Maybe if you take two right wrongs they'll make
one wrong right.
--
Thomas Viehmann, <http://thomas.viehmann.net/>
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| David Spreen 2004-09-26, 5:55 pm |
| -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Brian Nelson wrote:
|>
|>Fix the changelog in your local tree so that it properly documents the
|>real history of the package, but there's no need to upload until
|>something more important comes up.
|
|
| So then the bug submitters never see the real reason the bug was closed,
| apt-listchanges (presumably) suppresses the additions to the old
| changelog entry so that anyone with the package installed never sees the
| real entries... Plus, any maintainer clueless enough to write awful
| changelog entries is very likely a negligent maintainer, and thus highly
| unlikely to make an upload to fix "something more important" for many
| months. Why is this an OK situation? Is this to work around gimped
| architectures with broken autobuilders?
|
I totally agree. Besides this, the changelog is a part of the package
and not a less important one than for example a README or something like
this. I have actually seen uploads fixing one stupid typo in
documentation. I think it's preferable if changelogs are fixed immediately.
best regards,
david
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBVtzkdhEvvPyx3SMRAvDqAKCAy2MLSsDZ
lpqhv1r6xxclh1vwZwCfUflG
txcEPV6y6dTc87ZP/B8PKoc=
=yvyq
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Thomas Bushnell BSG 2004-09-26, 5:55 pm |
| Brian Nelson <pyro@debian.org> writes:
> On Sat, Sep 25, 2004 at 02:35:47PM -0500, Adam Heath wrote:
>
> I disagree. Documenting the changes made to a package is a very
> important part of an upload.
Yes, but closing a bug which involves no change to the package is not
a "change in the package".
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| David Spreen 2004-09-26, 5:55 pm |
| -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
hey there,
Thomas Bushnell BSG wrote:
| Yes, but closing a bug which involves no change to the package is not
| a "change in the package".
then the bug must not be closed using the changelog but via the
control-interface of our bts.
....
david
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBVxeadhEvvPyx3SMRApFiAJ4twIfY0btX
nSsCQ4/XujJl0MPvTgCcC/vj
7+r/hockmCKNqITi2WM/cAw=
=ZSma
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Andreas Barth 2004-09-27, 5:56 pm |
| * David Spreen (netzwurm@debian.org) [040926 21:55]:
> Thomas Bushnell BSG wrote:
> | Yes, but closing a bug which involves no change to the package is not
> | a "change in the package".
> then the bug must not be closed using the changelog but via the
> control-interface of our bts.
the control interface is deprecated. Please use bugnumber-done for
closing bugs.
Cheers,
Andi
--
http://home.arcor.de/andreas-barth/
PGP 1024/89FB5CE5 DC F1 85 6D A6 45 9C 0F 3B BE F1 D0 C5 D1 D9 0C
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
| |
| Colin Watson 2004-09-27, 5:56 pm |
| On Mon, Sep 27, 2004 at 10:41:22AM +0200, Andreas Barth wrote:
> * David Spreen (netzwurm@debian.org) [040926 21:55]:
>
>
> the control interface is deprecated.
(Only the 'close' command in that interface, of course, not the whole
interface!)
--
Colin Watson [cjwatson@debian.org]
--
To UNSUBSCRIBE, email to debian-devel-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
|
|
|
|
|