Hi,

please find the patch for JDO-58 attached. It includes the two changes
discussed in the mail thread JDO-58:

1) if (pmf!=null && pmf.isClosed())
pmf = null;

2) check for any instances or classes to be removed before we get a PMF
in tearDown.

Additionally, the patch includes some minor changes:

1) A final modifier for method "tearDown".

2) Methods "deleteAndUnregisterPCInstances" and
"deleteAndUnregisterPCClasses" have been renamed to
"deleteRemoveTearDownInstances" and "deleteRemoveTearDownClasses".

3) Method closePMF calls "pmf.isClosed()" before closing the PMF.

I ran the TCK with this patch. This result is:

Tests run: 349,  Failures: 14,  Errors: 81

Please note that this TCK test run includes the patch for JDO-1. With
patch for JDO-1 the two enhancer tests fail because they are
(unintentionally) still in the list of test cases to be executed. Thus,
if we exclude thw two from the list, then we have 12 Failues.

Regards,
Michael
--
-------------------------------------------------------------------
Michael Watzek                  Tech@Spree Engineering GmbH
mailto:mwa.tech@spree.de        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------

[ Post a follow-up to this message ]

Thanks, Michael.  I have checked in this patch.  For the record, I get
15 failures and 82 errors, using yesterday's build of JPOX run with
datastore identity.

-- Michelle

Michael Watzek wrote:

> Hi,
>
> please find the patch for JDO-58 attached. It includes the two changes
> discussed in the mail thread JDO-58:
>
> 1) if (pmf!=null && pmf.isClosed())
>     pmf = null;
>
> 2) check for any instances or classes to be removed before we get a PMF
> in tearDown.
>
> Additionally, the patch includes some minor changes:
>
> 1) A final modifier for method "tearDown".
>
> 2) Methods "deleteAndUnregisterPCInstances" and
> "deleteAndUnregisterPCClasses" have been renamed to
> "deleteRemoveTearDownInstances" and "deleteRemoveTearDownClasses".
>
> 3) Method closePMF calls "pmf.isClosed()" before closing the PMF.
>
> I ran the TCK with this patch. This result is:
>
> Tests run: 349,  Failures: 14,  Errors: 81
>
> Please note that this TCK test run includes the patch for JDO-1. With
> patch for JDO-1 the two enhancer tests fail because they are
> (unintentionally) still in the list of test cases to be executed.
> Thus, if we exclude thw two from the list, then we have 12 Failues.
>
> Regards,
> Michael

[ Post a follow-up to this message ]

[ Post a follow-up to this message ]

Hi Craig,

> Hi Michael,
>
> Just one comment. I'd change the name of
>
> deleteRemoveTearDownInstances to deleteTearDownInstances and
> deleteRemoveTearDownClasses to deleteTearDownClasses.
Ok.

Michael
>
> Craig
>
> On Jun 1, 2005, at 6:33 AM, Michael Watzek wrote:
> 
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!


--
-------------------------------------------------------------------
Michael Watzek                  Tech@Spree Engineering GmbH
mailto:mwa.tech@spree.de        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------

[ Post a follow-up to this message ]