[ [url]http://issues.apache.org/jira/browse/JDO-140?page=comments#action_12330391[/
url] ]

Michael Bouschen commented on JDO-140:
--------------------------------------

I have one comment about GetRollbackOnlyReturnsFalseUntilSet:

The assertion text of A13.4.5-2 has been changed in the current version o ft
he spec: "When a transaction is not active, and after a transaction is begun
, getRollbackOnly will return false. Once setRollbackOnly has been called, i
t will return true until co
mmit or rollback is called."

The test case implementation already covers the new version of the assertion
 text. I just propose to adapt the assertion text in the javadoc of the test
 case and in the spreadsheet.


> Add get/setRollbackOnly tests
> -----------------------------
>
>          Key: JDO-140
>          URL: http://issues.apache.org/jira/browse/JDO-140
>      Project: JDO
>         Type: Test
>   Components: tck20
>  Environment: TCK
>     Reporter: Craig Russell
>     Assignee: Craig Russell
>  Attachments: jdo140patch.txt
>
> There are two test classes for get/setRollbackOnly.
> One test class transactions.AfterSetRollbackOnlyCommitFails tests assertio
n A13.4.5-1
> Once a transaction has been marked for rollback via setRollbackOnly, the c
ommit method will always fail with JDOFatalDataStoreException.
> The strategy is to begin a transaction, set rollback only, and commit. The
 expected behavior is to catch an exception.
> The second test class transactions.GetRollbackOnlyReturnsFalseUntilSet tes
ts assertion A13.4.5-2
> After a transaction is begun, getRollbackOnly will return false until set 
commit or rollback is called.
> The strategy is to begin a transaction, test that getRollbackOnly is false, setRol
lbackOnly, and test that getRollbackOnly is true.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

[ Post a follow-up to this message ]