[ [url]http://issues.apache.org/jira/browse/JDO-215?page=comments#action_12358181[/
url] ]

Andy Jefferson commented on JDO-215:
------------------------------------

I see that the MetaData is now, for example
<field name="HashSetOfObject1" table="HASHSET_OF_OBJECT1">
<join column="IDENTIFIER"/>
<element>
<embedded>
<field name="id" primary-key="true" column="ID"/>
<field name="intField" column="INTVAL"/>
<field name="stringField" column="STRINGVAL"/>
</embedded>
</element>
</field>


That certainly doesnt agree with my definition of a PK specification for the
 join table. It should be (IMHO) like this

<join>
<primary-key>
<column name="IDENTIFIER"/>
<column name="ID"/>
</primary-key>
</join>
which nicely defines the colums to be used for the join table. Using fields 
of an embedded object and specifying primary-key there is not logical to me,
 and not supported by JPOX either. The JPOX online docs
http://www.jpox.org/docs/1_1/constraints.html
provides what we support for PK definition, which is that above.


> Remove <order> from mapping for HashSetCollections and SetCollections.
> ----------------------------------------------------------------------
>
>          Key: JDO-215
>          URL: http://issues.apache.org/jira/browse/JDO-215
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Reporter: Craig Russell
>     Assignee: Andy Jefferson
>  Attachments: JDO-215.patch
>
> The mapping for HashSetCollections and SetCollections incorrectly have <or
der> columns.
> There should not be an ordering specified for the join table since duplicates are 
not allowed. The mapping for application identity should not need a primary key, sin
ce the JDO implementation should be able to figure out that the primary key is part 
of
the Map.key, but the datastore identity mapping does need a primary key (and
 again, I'd use the id field of SimpleClass as the join table key column.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

[ Post a follow-up to this message ]