[ http://issues.apache.org/jira/browse/JDO-216?page=all ]

Michael Watzek resolved JDO-216:
--------------------------------

Resolution: Fixed

The attached patch has been checked in including the comments above (Revisio
v 345514).


> Result handling in class QueryTest must be capable to consider return type
s of java.lang.Object
> --------------------------------------------------------------------------
---------------------
>
>          Key: JDO-216
>          URL: http://issues.apache.org/jira/browse/JDO-216
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Reporter: Michael Watzek
>     Assignee: Michael Watzek
>  Attachments: JDO-216.patch
>
> The current result handling in class QueryTest cannot consider return types of typ
e java.lang.Object. Unique queries and queries using  aggregates in the select expre
ssion (single exression, no group by) return objects rather than collections. The re
sul
t handling must reflect this fact. As a consequence, the expected result in query test cases
 must be capable to consider a single object also.
> Currently, the expected result is declared as an object array in JDO2 query test c
lasses. Method QueryTest.execute takes an object array as the expected result and an
 additional flag (unique) indicating if the query returns a single result. The unqiu
e p
arameter is calculated by methods in QueryTest executing query element holders. This is inad
equate because the query element holder does not encapsulate the information of aggregates i
n single result expressions.
> We propose to adapt the signature and the implementation of method QueryTe
st.execute: The expected result should be of type java.lang.Object and the u
nique parameter should be removed. Thus, the unique information can be calcu
lated inside the method.
> JDO2 query test classes in package query.api call method QueryTest.execute
 directly. These test cases must be adapted wrt the expected result: The exp
ected result must be of the exact type which the query returns at runtime.
> Other test cases which do not call method QueryTest.execute directly may be adapte
d wrt the expected result as part of a separate issue.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

[ Post a follow-up to this message ]