Hi Craig,

> Hi Michael,
>
> Test class DeleteQueryElements has INVALID_QUERIES for which the
> comments are incorrect. They should all start with "The query is
> invalid because...". I suspect that you copied some of these from  other
> query tests, but there are more requirements for delete.
>
> For example, I suggest changing "The query may fail because there is  a
> grouping clause, or because there is a grouping clause w/o result"  to
> "The query is invalid because there is a grouping clause".
Ok.

>
> I'd also suggest making two test cases from the test case"The query  may
> fail because there is a result, or  because there is a result  class".
> These sound like different cases.
I assume, you mean two different test methods, rather than two different
test classes?

Up to now, all JDO2 query test classes implementing negative test cases
execute those within the same method (testNegative()). For example, test
class DeleteQueryElements executes the following test cases within
testNegative():

1) invalid result clause,
2) invalid result class,
3) invalid grouping,
4) invalid ordering,
5) invalid range.

Is your suggestion to split up 1) - 5) into different negative test
methods?

If yes, I propose to make a separate issue out of it because this
affects more classes than just DeleteQueryElements. There are several
JDO2 query test classes executing more than one test case within
testNegative().

Regards,
Michael
>
> I notice in QueryTest that the execute method always starts a
> transaction. Are there any tests that query outside a transaction?
>
> Thanks,
>
> Craig
>
> On Nov 28, 2005, at 5:08 AM, Michael Watzek (JIRA) wrote:
> 
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
>


--
-------------------------------------------------------------------
Michael Watzek                  Tech@Spree Engineering GmbH
mailto:mwa.tech@spree.de        Buelowstr. 66
Tel.:  ++49/30/235 520 36       10783 Berlin - Germany
Fax.:  ++49/30/217 520 12       http://www.spree.de/
-------------------------------------------------------------------

[ Post a follow-up to this message ]