[ http://issues.apache.org/jira/brows...comments#actio=
n_12358902 ]=20

Emmanuel Lecharny commented on DIRLDAP-75:
------------------------------------------

Thanks for the report !

You have to know that Twix is not already official (you can use it, but it'=
s still beta) and that Snickers is the 'legacy' codec. Snacc will be 'termi=
nated' soon.

so, on your points :

1) yes, this is a good idea.

2) ok, that's also a good idea

3) bloody hell ! a NPE... I have to double check the problem. I think that =
the init is not correct.

4) oopps. I commented this one for testing purpose, but I forgot to impleme=
nted it after having tested the code... My very bad !

Thanks to you Van !

-- Emmanuel L=C3=A9charny

> Twix Support for LDAP Controls
> ------------------------------
>
>          Key: DIRLDAP-75
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-75
>      Project: Directory LDAP
>         Type: Bug
>   Components: Common
>     Versions: 0.9.3
>     Reporter: Van Nhu
>  Attachments: TwixProviderTest.java, better_twix_support_for_ldap_control=
s.patch
>
> Please excuse my limited understanding of the LDAP Common source base, bu=
t it seems that the support for LDAP controls in the TwixTransformer is not=
complete. So I've made the following modifications to the LDAP Common modu=
le in order to have my Virtual Directory to correctly process the various L=
DAP controls:
> 1. Get the Twix Control class to implement the javax.naming.ldap.Control =
interface. Firstly, this is because Twix Controls are really LDAP Controls,=
and secondly, this makes it easier to create an org.apache.ldap.common.mes=
sage.ControlImpl instance from a Twix Control object.
> 2. Remove the extraneous method declarations in org.apache.ldap.common.me=
ssage.Control because they are already defined in javax.naming.ldap.Control
> 3. Fix a NullPointerException in org.apache.asn1new.ldap.pojo.LdapMessage=
.addControl() method
> 4. Implement the method org.apache.asn1new.ldap.TwixTransformer.transform=
Controls() so that the Response Controls are propagated to the LDAP client =
properly.
> The patch and the unit tests will be attached here shortly for your refer=
ence.
> Thanks and Regards,
> Van

--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secur...nistrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira

[ Post a follow-up to this message ]