[ http://issues.apache.org/jira/brows...ER-730?page=all ]

Bastiaan Bakker updated DIRSERVER-730:
--------------------------------------

Attachment: apacheds-daemon-trunk-serverinit.patch

the attached patch tackles the issue by replacing 'success' and 'failure' wi
th 'log_success_msg' and 'log_failure_msg' from LSB. Since OpenSUSE is LSB c
ompliant this should work on SUSE as well.
In case LSB is not available the script falls back to using 'echo -n success
' and 'echo -n failure'.
Other changes:
* use /bin/sh instead of /bin/bash
return $RETVAL instead of $? because $? may be overwritten by the log functi
ons.


> init script fails due to missing commands "success" and "failure"
> -----------------------------------------------------------------
>
>                 Key: DIRSERVER-730
>                 URL: http://issues.apache.org/jira/browse/DIRSERVER-730
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0-RC4
>         Environment: OpenSuSE 10.0
>            Reporter: Michael Henry
>         Assigned To: Alex Karasulu
>             Fix For: 1.0
>
>         Attachments: apacheds-daemon-trunk-serverinit.patch
>
>
> Here is the output for startup:
> samsara:~ # /etc/init.d/apacheds start
> JAVA_HOME=/usr/lib/jvm/java
> APACHEDS_HOME=/usr/local/apacheds-1.0_RC4
> CLASSPATH=:/usr/lib/jvm/java/lib/tools.jar:/usr/local/apacheds-1.0_RC4/bin
/bootstrapper.jar:/usr/local/apacheds-1.0_RC4/bin/logger.jar:/usr/local/apac
heds-1.0_RC4/bin/daemon.jar
> Starting apacheds server: /etc/init.d/apacheds: line 155: success: command
 not found
> /etc/init.d/apacheds: line 156: failure: command not found
> ...and shutdown:
> samsara:/etc/init.d # ./apacheds stop
> JAVA_HOME=/usr/lib/jvm/java
> APACHEDS_HOME=/usr/local/apacheds-1.0_RC4
> CLASSPATH=:/usr/lib/jvm/java/lib/tools.jar:/usr/local/apacheds-1.0_RC4/bin
/bootstrapper.jar:/usr/local/apacheds-1.0_RC4/bin/logger.jar:/usr/local/apac
heds-1.0_RC4/bin/daemon.jar
> Shutting down apacheds server: ./apacheds: line 188: success: command not 
found
> ./apacheds: line 189: failure: command not found
> Both cases have the exact same problem so I will just cover the startup ca
se.
> Lines 155 and 156 are:
>         [ "$RETVAL" -eq 0 ] && success $"apacheds server startup" || \
>              failure $"apacheds server start"
> My guess is that "success" and "failure" are functions which are expected 
to be defined in the following which starts at line 14:
> # Source function library.
> if [ -f /etc/init.d/functions ] ; then
>      . /etc/init.d/functions
> fi
> The file /etc/init.d/functions doesn't exist on SuSE platforms.
> A possible fix would be to define a variable such as "FUNCTIONS_EXIST=true
" inside the if statement and systems for which the functions do not exist c
ould be lumped in with SunOS in the switch statements.
> *** apacheds    Thu Sep  7 14:39:26 2006
> --- apacheds.old        Thu Sep  7 14:36:44 2006
> ***************
> *** 11,20 ****
>   export DISPLAY
>   # Source function library.
> - FUNCTIONS_EXIST=false
>   if [ -f /etc/init.d/functions ] ; then
>        . /etc/init.d/functions
> -      FUNCTIONS_EXIST=true
>   fi
>   # Source networking configuration.
> --- 11,18 ----
> ***************
> *** 150,156 ****
>       if [ `uname` = "Darwin" ] ; then
>           [ "$RETVAL" -eq 0 ] && echo successful apacheds server start
up || \
>                echo failed apacheds server start
> !     elif [ `uname` = "SunOS" ] || ! $FUNCTIONS_EXIST; then
>           [ "$RETVAL" -eq 0 ] && echo success apacheds server startup 
|| \
>                echo failure apacheds server start
>       else
> --- 148,154 ----
>       if [ `uname` = "Darwin" ] ; then
>           [ "$RETVAL" -eq 0 ] && echo successful apacheds server start
up || \
>                echo failed apacheds server start
> !     elif [ `uname` = "SunOS" ] ; then
>           [ "$RETVAL" -eq 0 ] && echo success apacheds server startup 
|| \
>                echo failure apacheds server start
>       else
> ***************
> *** 181,187 ****
>       if [ `uname` = "Darwin" ] ; then
>           [ "$RETVAL" -eq 0 ] && echo successful apacheds server shutd
own || \
>                echo failed apacheds server shutdown
> !     elif [ `uname` = "SunOS" ] || ! $FUNCTIONS_EXIST; then
>           [ "$RETVAL" -eq 0 ] && echo success apacheds server shutdown
 || \
>                echo failure apacheds server shutdown
>       else
> --- 179,185 ----
>       if [ `uname` = "Darwin" ] ; then
>           [ "$RETVAL" -eq 0 ] && echo successful apacheds server shutd
own || \
>                echo failed apacheds server shutdown
> !     elif [ `uname` = "SunOS" ] ; then
>           [ "$RETVAL" -eq 0 ] && echo success apacheds server shutdown
 || \
>                echo failure apacheds server shutdown
>       else
> EOF

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://iss
ues.apache.org/ji...nistrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ Post a follow-up to this message ]