Potential memory leak in req.readlines().
-----------------------------------------

Key: MODPYTHON-211
URL: https://issues.apache.org/jira/browse/MODPYTHON-211
Project: mod_python
Issue Type: Bug
Components: core
Affects Versions: 3.2.10, 3.3
Reporter: Graham Dumpleton


This code in req.readlines() looks a bit fishy to me and possibly leaks memo
ry. The code in question is:

rlargs = PyTuple_New(0);
if (result == NULL)
return PyErr_NoMemory();

line = req_readline(self, rlargs);
while (line && ((linesize=PyString_Size(line))>0)) {
PyList_Append(result, line);
size += linesize;
if ((sizehint != -1) && (size >= sizehint))
break;
Py_DECREF(line);
line = req_readline(self, args);
}
Py_XDECREF(line);

The thing that looks wrong is 'rlargs'. This is created, used in a sub call 
to req_readline() but then never destroyed. Thus, possibly a memory leak.

[ Post a follow-up to this message ]