[ https://issues.apache.org/jira/brow...ls:all-tabpanel ]

Michelle Caisse updated JDO-433:
--------------------------------

Attachment: JDO-433.patch

Patch to resolve this issue is attached.  Affects JDO_Test.java and a number
 of tests in the persistencemanagerfactory package.

> setUp() is not declared final in org.apache.jdo.tck.JDO_Test
> ------------------------------------------------------------
>
>                 Key: JDO-433
>                 URL: https://issues.apache.org/jira/browse/JDO-433
>             Project: JDO
>          Issue Type: Bug
>          Components: tck2
>    Affects Versions: JDO 2 final
>            Reporter: Michelle Caisse
>         Assigned To: Michelle Caisse
>            Priority: Minor
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDO-433.patch
>
>
> Tests are to override localSetUp() for test specific set up.  The setUp() method i
n JDO_Test is not meant to be overriden.  However, it is not currently declared to b
e final.  It should be declared final and the set up code in the tests that do overr
ide
setUp() (listed below) should be in localSetUp().
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
GetPersistenceManager.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerf
actory.GetPersistenceManager cannot override setUp() in org.apache.jdo.tck.JDO_Test;
 ov
erridden method is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
 GetPersistenceManagerFactoryByProperties
Instance.java:60: setUp() in org.apache.jdo.
tck.api.persistencemanagerfactory. GetPersistenceManagerFactoryByProperties
Instance c
ann
ot override setUp() in org.apache.jdo.tck.JDO_Test; overridden method is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
GetPersistenceManagerForUser.java:63: setUp() in org.apache.jdo.tck.api.persistencem
anagerfactory.GetPersistenceManagerForUser cannot override setUp() in org.apache.jdo
.tc
k.JDO_Test; overridden method is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetConnectionPassword.java:54: setUp() in org.apache.jdo.tck.api.persistencemanagerf
actory.SetConnectionPassword cannot override setUp() in org.apache.jdo.tck.JDO_Test;
 ov
erridden method is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetConnectionURL.java:58: setUp() in org.apache.jdo.tck.api.persistencemanagerfactor
y.SetConnectionURL cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridde
n m
ethod is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetConnectionUserName.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerf
actory.SetConnectionUserName cannot override setUp() in org.apache.jdo.tck.JDO_Test;
 ov
erridden method is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetIgnoreCache.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.
SetIgnoreCache cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden me
tho
d is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetMultithreaded.java:57: setUp() in org.apache.jdo.tck.api.persistencemanagerfactor
y.SetMultithreaded cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridde
n m
ethod is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetNonTransactionalRead.java:54: setUp() in org.apache.jdo.tck.api.persistencemanage
rfactory.SetNonTransactionalRead cannot override setUp() in org.apache.jdo.tck.JDO_T
est
; overridden method is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetNonTransactionalWrite.java:54: setUp() in org.apache.jdo.tck.api.persistencemanag
erfactory.SetNonTransactionalWrite  cannot override setUp() in org.apache.jdo.tck.JD
O_T
est; overridden method is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetOptimistic.java:53: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory.S
etOptimistic cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden meth
od
is final
>    protected void setUp() throws Exception {
>                   ^
>  C:\svn0\jdo\trunk\tck20\src\java\org\apa
 che\jdo\tck\api\persistencemanagerfactor
y\
SetRetainValues.java:55: setUp() in org.apache.jdo.tck.api.persistencemanagerfactory
.SetRetainValues cannot override setUp() in org.apache.jdo.tck.JDO_Test; overridden 
met
hod is final
>    protected void setUp() throws Exception {
>                   ^

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[ Post a follow-up to this message ]