[ https://issues.apache.org/jira/brow...ls:all-tabpanel ]

lizongbo updated DIRSERVER-1093:
--------------------------------

Attachment: testcommand.jpg

The test Comman

> the ResourceRecordEncoder and QuestionRecordEncoder have bug for empty dom
ainName
> --------------------------------------------------------------------------
----------
>
>                 Key: DIRSERVER-1093
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1093
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: dns
>    Affects Versions: 1.5.1
>         Environment: Windows XP , apacheds-protocol-dns-1.5.1.jar
>            Reporter: lizongbo
>         Attachments: error4trace.jpg, testcommand.jpg
>
>
> When I use dig trace  for Test the apache dns server.   the QuestionRecord
 and ResourceRecord not encoded right for the empty Domain Name.
> my Test command is:
> E:\bind>dig @10.108.20.126 618119.com +trace
> Then found this bug is caeused by the method "encodeDomainName" in Questio
nRecordEncoder.java and "putDomainName" in ResourceRecordEncoder.java.
> follow code can be test to get  "labels.length == 1";
> [code]
>         String s = "";
>         String[] labels = new String[0];
>         labels = s.split("\\.");
>         System.out.println("labels.length == " + labels.length);
> [/code]
> so  i fix this bug by follow change :
> [code]
>  String[] labels = domainName.split( "\\." );
> [/code]
> change to:
> [code]
>         String[] labels = new String[0];
>         if (domainName != null && domainName.length() > 0) {
>             labels = domainName.split("\\.");
>         }
> [/code]
> Please fix the bug

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[ Post a follow-up to this message ]